B2SAFE Core issueshttps://gitlab.eudat.eu/b2safe/B2SAFE-core/-/issues2023-10-05T15:50:48+02:00https://gitlab.eudat.eu/b2safe/B2SAFE-core/-/issues/11Install_other.md wants to install from GitHub (instead of Gitlab)2023-10-05T15:50:48+02:00Marvin WinkensInstall_other.md wants to install from GitHub (instead of Gitlab)See [here](https://gitlab.eudat.eu/b2safe/B2SAFE-core/-/blob/master/install_other.md?plain=1#L23).
Shouldn't this link to this repository?See [here](https://gitlab.eudat.eu/b2safe/B2SAFE-core/-/blob/master/install_other.md?plain=1#L23).
Shouldn't this link to this repository?https://gitlab.eudat.eu/b2safe/B2SAFE-core/-/issues/10implement testing of B2SAFE against iRODS 4_3_02023-10-06T11:38:22+02:00Robert Verkerkimplement testing of B2SAFE against iRODS 4_3_0Once the Centos7_4_3_0 docker image has been created test it against B2SAFE
Use the same rpm as created on iRODS 4.2.11. If it passes it is OK.Once the Centos7_4_3_0 docker image has been created test it against B2SAFE
Use the same rpm as created on iRODS 4.2.11. If it passes it is OK.https://gitlab.eudat.eu/b2safe/B2SAFE-core/-/issues/9create rpm's and put them in repo's using the branch name2022-07-27T15:19:15+02:00Robert Verkerkcreate rpm's and put them in repo's using the branch nameAt the moment all rpm's which are created go to the repo `irods-eudat-b2safe`. This is confusing for users. Especially when we have multiple branches. And you only want the users to use the rpm from the master branch.
So when writing/cr...At the moment all rpm's which are created go to the repo `irods-eudat-b2safe`. This is confusing for users. Especially when we have multiple branches. And you only want the users to use the rpm from the master branch.
So when writing/creating the rpm on gitlab use the following:
* irods-eudat-b2safe
* irods-eudat-b2safe_devel
* irods-eudat-b2safe_implement_pyhandle
* irods-eudat-b2safe_\<branchname\>
The first one is used for the master or main branch. The rest is used for the specific branches.
Action plan:
* create a new branch from devel to implement the rpm output naming scheme
* implement the rpm output naming scheme
* merge the new branch to the devel branch
* merge the devel branch to the master branchRobert VerkerkRobert Verkerk2022-08-31https://gitlab.eudat.eu/b2safe/B2SAFE-core/-/issues/7change epicclient2.py to use pyhandle instead of b2handle2022-07-27T15:18:29+02:00Robert Verkerkchange epicclient2.py to use pyhandle instead of b2handleAt the moment epicclient2.py tries to use b2handle.
In the new version of b2safe pyhandle is being used.
epicclient2.py is still delivered with the system.
update the code so it will use pyhandle instead of b2handle.
Change for instance:...At the moment epicclient2.py tries to use b2handle.
In the new version of b2safe pyhandle is being used.
epicclient2.py is still delivered with the system.
update the code so it will use pyhandle instead of b2handle.
Change for instance:
```
from b2handle.handleclient import EUDATHandleClient
from b2handle.clientcredentials import PIDClientCredentials
from b2handle.handleexceptions import *
```
to:
```
from pyhandle.handleclient import PyHandleClient
from pyhandle.clientcredentials import PIDClientCredentials
from pyhandle.handleexceptions import *
```
Also change the appropiate calls in the code:
```
$ grep EUDAT epicclient2.py
...
client = EUDATHandleClient.instantiate_with_credentials(
client = EUDATHandleClient.instantiate_with_credentials(
client = EUDATHandleClient.instantiate_with_credentials(
client = EUDATHandleClient.instantiate_with_credentials(
client = EUDATHandleClient.instantiate_with_credentials(
client = EUDATHandleClient.instantiate_with_credentials(
client = EUDATHandleClient.instantiate_with_credentials(
...
```
Action plan:
* create a new branch from the devel branch.
* update here the code and test it
* merge the code in the new branch to the devel branch
* merge the devel branch to the master branchRobert VerkerkRobert Verkerk2022-08-31https://gitlab.eudat.eu/b2safe/B2SAFE-core/-/issues/6Migrate worflows to harbor repository2023-10-27T14:33:29+02:00Stefan WolfsheimerMigrate worflows to harbor repositoryhttps://gitlab.eudat.eu/b2safe/B2SAFE-core/-/issues/5Broken link in README.md2023-10-27T16:00:53+02:00Kees van ReeuwijkBroken link in README.mdIn the file https://gitlab.eudat.eu/b2safe/B2SAFE-core/-/blob/master/README.md there is the sentence 'The documetation can be found in the [B2SAFE-wiki](https://gitlab.eudat.ei/b2safe/B2SAFE-core/-/wikis)'. The link in that sentence is b...In the file https://gitlab.eudat.eu/b2safe/B2SAFE-core/-/blob/master/README.md there is the sentence 'The documetation can be found in the [B2SAFE-wiki](https://gitlab.eudat.ei/b2safe/B2SAFE-core/-/wikis)'. The link in that sentence is broken (probably '.ei' -> '.eu').https://gitlab.eudat.eu/b2safe/B2SAFE-core/-/issues/4epicclient2.py uses epic5.storage.surfsara.nl and NOT epic-pid.storage.surfsa...2020-06-17T14:06:54+02:00Robert Verkerkepicclient2.py uses epic5.storage.surfsara.nl and NOT epic-pid.storage.surfsara.nlIt would be better to use `epic-pid.storage.surfsara.nl` wherever it states `epic5.storage.surfsara.nl`.
This for the epicclient configuration and the msipid configuration.
This because it is a floating IP address which resolves to the ...It would be better to use `epic-pid.storage.surfsara.nl` wherever it states `epic5.storage.surfsara.nl`.
This for the epicclient configuration and the msipid configuration.
This because it is a floating IP address which resolves to the active handle server. Otherwise it is hardcoded to one server.https://gitlab.eudat.eu/b2safe/B2SAFE-core/-/issues/3msipid tests are not being run.2021-04-22T22:24:00+02:00Robert Verkerkmsipid tests are not being run.There are tests for the msipid integration. They are not being run. It would be nice to add them to be executed.
* set parameters
```
export prefix=21.T12996
export url_prefix_in_profile='true'
```
* run test:
```
./testB2SafeCmd.py -te...There are tests for the msipid integration. They are not being run. It would be nice to add them to be executed.
* set parameters
```
export prefix=21.T12996
export url_prefix_in_profile='true'
```
* run test:
```
./testB2SafeCmd.py -test msipid
Test msiPid Script
test_create_handle (testB2SafeCmd.msipidintgtest.MsiPidIntegrationTests)
Test that create handle returns expected response and adds new handle. ... ERROR
test_create_handle_with_checksum (testB2SafeCmd.msipidintgtest.MsiPidIntegrationTests)
Test that create handle with checksum returns expected response and adds new handle with supplied checksum. ... ok
test_create_handle_with_extra_key (testB2SafeCmd.msipidintgtest.MsiPidIntegrationTests)
Test that create handle with extra key returns expected response and adds new handle with supplied key value. ... ok
test_create_handle_with_extra_key_FIO_PID (testB2SafeCmd.msipidintgtest.MsiPidIntegrationTests)
Test that create handle with extra key EUDAT/FIO and value 'PID' returns expected response and adds new handle with supplied key value. ... ok
test_create_handle_with_extra_key_FIO_real_pid (testB2SafeCmd.msipidintgtest.MsiPidIntegrationTests)
Test that create handle with extra key EUDAT/FIO returns expected response and adds new handle with supplied key value. ... ok
test_create_handle_with_extra_key_ROR_pid (testB2SafeCmd.msipidintgtest.MsiPidIntegrationTests)
Test that create handle with extra key EUDAT/ROR and value 'pid' returns expected response and adds new handle with supplied key value. ... ok
test_create_handle_with_extra_key_ROR_real_pid (testB2SafeCmd.msipidintgtest.MsiPidIntegrationTests)
Test that create handle with extra key EUDAT/ROR returns expected response and adds new handle with supplied key value. ... ok
test_delete_handle (testB2SafeCmd.msipidintgtest.MsiPidIntegrationTests)
Test that delete existing handle returns 0. ... ok
test_delete_key_from_handle (testB2SafeCmd.msipidintgtest.MsiPidIntegrationTests)
Test that delete key from handle returns 0. ... ok
test_delete_non_existing_handle (testB2SafeCmd.msipidintgtest.MsiPidIntegrationTests)
Test that delete non existing handle returns -1090000. ... ok
test_modify_handle_key_value_1 (testB2SafeCmd.msipidintgtest.MsiPidIntegrationTests)
Test that modify handle value returns handle and updates stored value. ... ok
test_modify_handle_key_value_2 (testB2SafeCmd.msipidintgtest.MsiPidIntegrationTests)
Test that modify handle value returns handle and updates stored value. ... ok
test_modify_handle_key_value_3 (testB2SafeCmd.msipidintgtest.MsiPidIntegrationTests)
Test that modify handle value returns handle and updates stored value. ... ok
test_modify_handle_new_key_value_1 (testB2SafeCmd.msipidintgtest.MsiPidIntegrationTests)
Test that modify existing handle with new key-value pair returns 0 and updates stored handle. ... ok
test_modify_handle_new_key_value_2 (testB2SafeCmd.msipidintgtest.MsiPidIntegrationTests)
Test that modify existing handle with new key-value pair returns 0 and updates stored handle. ... ok
test_modify_handle_new_key_value_3 (testB2SafeCmd.msipidintgtest.MsiPidIntegrationTests)
Test that modify existing handle with new key-value pair returns 0 and updates stored handle. ... ok
test_modify_handle_new_key_value_4 (testB2SafeCmd.msipidintgtest.MsiPidIntegrationTests)
Test that modify existing handle with new key-value pair returns 0 and updates stored handle. ... ok
test_modify_handle_new_key_value_5 (testB2SafeCmd.msipidintgtest.MsiPidIntegrationTests)
Test that modify existing handle with new key-value pair returns 0 and updates stored handle. ... ok
test_modify_handle_with_empty_value (testB2SafeCmd.msipidintgtest.MsiPidIntegrationTests)
Test that modify existing handle key with empty value returns 0 and updates stored value accordingly. ... ok
test_modify_non_existing_handle (testB2SafeCmd.msipidintgtest.MsiPidIntegrationTests)
Test that modify value of non existing handle returns -1090000. ... ok
test_read_non_existing_handle (testB2SafeCmd.msipidintgtest.MsiPidIntegrationTests)
Test that read non existing handle returns -1090000. ... ok
test_read_non_existing_value_from_handle (testB2SafeCmd.msipidintgtest.MsiPidIntegrationTests)
Test that read value by non existing key returns -1090000. ... ok
test_read_value_from_handle (testB2SafeCmd.msipidintgtest.MsiPidIntegrationTests)
Test that read value by key returns stored handle value. ... ok
test_read_value_from_non_existing_handle (testB2SafeCmd.msipidintgtest.MsiPidIntegrationTests)
Test that read value by key from non existing handle returns -1090000. ... ok
test_search_handle_by_key_value (testB2SafeCmd.msipidintgtest.MsiPidIntegrationTests)
Test that search by key-value returns matching handle. ... FAIL
test_search_handle_by_non_existing_key_value (testB2SafeCmd.msipidintgtest.MsiPidIntegrationTests)
Test that search handle by non existing key-value returns ''. ... ok
======================================================================
ERROR: test_create_handle (testB2SafeCmd.msipidintgtest.MsiPidIntegrationTests)
Test that create handle returns expected response and adds new handle.
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/robertv/git/B2SAFE-core/scripts/tests/testB2SafeCmd/msipidintgtest.py", line 339, in test_create_handle
self.assertEqual(unicode(create_result[1]).lower(), lookup_result[1].lower(),
IndexError: list index out of range
======================================================================
FAIL: test_search_handle_by_key_value (testB2SafeCmd.msipidintgtest.MsiPidIntegrationTests)
Test that search by key-value returns matching handle.
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/robertv/git/B2SAFE-core/scripts/tests/testB2SafeCmd/msipidintgtest.py", line 259, in test_search_handle_by_key_value
'search existing handle by key returns unexpected response')
AssertionError: search existing handle by key returns unexpected response
----------------------------------------------------------------------
Ran 26 tests in 31.375s
```https://gitlab.eudat.eu/b2safe/B2SAFE-core/-/issues/2epic2 and b2safe tests have problems because the https_verify has been set to...2020-10-01T15:50:59+02:00Robert Verkerkepic2 and b2safe tests have problems because the https_verify has been set to false.It gives a lot off:
```
/usr/local/lib/python3.6/site-packages/urllib3/connectionpool.py:986: InsecureRequestWarning: Unverified HTTPS request is being made to host 'epic5.storage.surfsara.nl'. Adding certificate verification is strongly...It gives a lot off:
```
/usr/local/lib/python3.6/site-packages/urllib3/connectionpool.py:986: InsecureRequestWarning: Unverified HTTPS request is being made to host 'epic5.storage.surfsara.nl'. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
```
This could be prevented by two things:
* Add a CA certificate file on the running system
* adjust the credentials file and have HTTPS_VERIFY point to the file.