Some Additions and Simplifications by TUEIESM
Hi @lena.feld, hi @benedikt.herkommer,
I am Moritz, a research assistant at TUM working with Jia Chen, Florian Dietrich and Patrick Aigner.
Here are some proposed changes for the proffastpylot project:
- We use a datalogger format where the pressure is given in "BaroYoung" instead of "BaroTHB40". Hence, I added a new pressure format for that. It would be nice to have custom formats included in the codebase so that future upgrades are easy and we don't have to manually change stuff.
- The filtering of days by start-/end-date did not work for me. I fixed that in
prepare.py
and reduced the complexity there. I changed the start-/end-date format fromYYYY-MM-DD
toYYMMDD
- the same format as the ifg's themselves are supposed to be in. - In the get-dates function there was a TODO to only use date folders with a valid
YYMMDD
format. I added a - I fixed a typo in
prepare.py
(line 82)
I have a few more suggestions for the project. If you want and have time, we can sit down to talk about these.
Best regards, Moritz
Edited by Moritz Makowski